Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: ios/chrome/browser/favicon/large_icon_cache_unittest.cc

Issue 2374753002: Track when fallback icon color is the default. (Closed)
Patch Set: Merge branch 'refs/heads/master' into default-color Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon_base/fallback_icon_url_parser_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/favicon/large_icon_cache_unittest.cc
diff --git a/ios/chrome/browser/favicon/large_icon_cache_unittest.cc b/ios/chrome/browser/favicon/large_icon_cache_unittest.cc
index 020c442ec7ad9c2e72fe8fe092692d6a14c98ff3..c9823f4ee803d528e3435d8f745736b3c77634f8 100644
--- a/ios/chrome/browser/favicon/large_icon_cache_unittest.cc
+++ b/ios/chrome/browser/favicon/large_icon_cache_unittest.cc
@@ -43,6 +43,7 @@ class LargeIconCacheTest : public testing::Test {
LargeIconCacheTest() {
expected_fallback_icon_style_.reset(new favicon_base::FallbackIconStyle());
expected_fallback_icon_style_->background_color = kTestColor;
+ expected_fallback_icon_style_->is_default_background_color = false;
expected_bitmap_ = CreateTestBitmap(24, 24, kTestColor);
large_icon_cache_.reset(new LargeIconCache);
}
@@ -86,6 +87,7 @@ TEST_F(LargeIconCacheTest, RetreiveItem) {
EXPECT_EQ(false, result2->bitmap.is_valid());
EXPECT_EQ(expected_result2->fallback_icon_style->background_color,
result2->fallback_icon_style->background_color);
+ EXPECT_FALSE(result2->fallback_icon_style->is_default_background_color);
// Test overwriting kDummyUrl.
large_icon_cache_->SetCachedResult(GURL(kDummyUrl), *expected_result2);
@@ -94,6 +96,7 @@ TEST_F(LargeIconCacheTest, RetreiveItem) {
EXPECT_EQ(false, result3->bitmap.is_valid());
EXPECT_EQ(expected_result2->fallback_icon_style->background_color,
result3->fallback_icon_style->background_color);
+ EXPECT_FALSE(result2->fallback_icon_style->is_default_background_color);
}
} // namespace
« no previous file with comments | « components/favicon_base/fallback_icon_url_parser_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698