chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java - Issue 2374753002: Track when fallback icon color is the default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java

Issue 2374753002: Track when fallback icon color is the default. (Closed)

Patch Set: Merge branch 'refs/heads/master' into default-color Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/favicon/LargeIconBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java

index ebdcb82697f2ba9d4c5637a4f15d727760180a1a..3a5360ff265faa4efb0188161a49001948f15198 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java

@@ -240,7 +240,8 @@ public class BookmarkWidgetService extends RemoteViewsService {

mRemainingTaskCount++;

LargeIconCallback callback = new LargeIconCallback() {

@Override

- public void onLargeIconAvailable(Bitmap icon, int fallbackColor) {

+ public void onLargeIconAvailable(

+ Bitmap icon, int fallbackColor, boolean isFallbackColorDefault) {

if (icon == null) {

mIconGenerator.setBackgroundColor(fallbackColor);

icon = mIconGenerator.generateIconForUrl(bookmark.url);