chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java - Issue 2374753002: Track when fallback icon color is the default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java

Issue 2374753002: Track when fallback icon color is the default. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/favicon/LargeIconBridge.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java

index 2179a38b09bba8142dde01488c315ec51cd1acd6..afb361fd958cc314438d591b36888a9edf690f63 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java

@@ -80,7 +80,7 @@ public class BookmarkItemRow extends BookmarkRow implements LargeIconCallback {

// LargeIconCallback implementation.

@Override

- public void onLargeIconAvailable(Bitmap icon, int fallbackColor) {

+ public void onLargeIconAvailable(Bitmap icon, int fallbackColor, boolean isDefaultColor) {

if (icon == null) {

mIconGenerator.setBackgroundColor(fallbackColor);

icon = mIconGenerator.generateIconForUrl(mUrl);