Track when fallback icon color is the default.

ios/chrome/browser/favicon/large_icon_cache_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/favicon/large_icon_cache.h"
 
 #include "base/macros.h"
 #include "components/favicon_base/fallback_icon_style.h"
 #include "components/favicon_base/favicon_types.h"
 #include "skia/ext/skia_utils_ios.h"
@@ skipping 25 matching lines @@
   result.icon_type = favicon_base::TOUCH_ICON;
   CHECK(result.is_valid());
   return result;
 }
 
 class LargeIconCacheTest : public testing::Test {
  public:
   LargeIconCacheTest() {
     expected_fallback_icon_style_.reset(new favicon_base::FallbackIconStyle());
     expected_fallback_icon_style_->background_color = kTestColor;
+    expected_fallback_icon_style_->is_default_background_color = false;
     expected_bitmap_ = CreateTestBitmap(24, 24, kTestColor);
     large_icon_cache_.reset(new LargeIconCache);
   }
 
   ~LargeIconCacheTest() override {}
 
  protected:
   std::unique_ptr<LargeIconCache> large_icon_cache_;
   favicon_base::FaviconRawBitmapResult expected_bitmap_;
   std::unique_ptr<favicon_base::FallbackIconStyle>
@@ skipping 22 matching lines @@
 
   std::unique_ptr<favicon_base::LargeIconResult> result1 =
       large_icon_cache_->GetCachedResult(GURL(kDummyUrl));
   EXPECT_EQ(true, result1->bitmap.is_valid());
   EXPECT_EQ(expected_result1->bitmap.pixel_size, result1->bitmap.pixel_size);
 
   std::unique_ptr<favicon_base::LargeIconResult> result2 =
       large_icon_cache_->GetCachedResult(GURL(kDummyUrl2));
   EXPECT_EQ(false, result2->bitmap.is_valid());
   EXPECT_EQ(expected_result2->fallback_icon_style->background_color,
             result2->fallback_icon_style->background_color);

[pkotwicz, 2016/09/28 03:52:52]

Shouldn't you also test:

EXPECT_EQ(expected_result2->fallback_icon_style->is_default_background_color,
result2->fallback_icon_style->is_default_background_color)

[sfiera, 2016/09/28 13:15:52]

Done.

 
   // Test overwriting kDummyUrl.
   large_icon_cache_->SetCachedResult(GURL(kDummyUrl), *expected_result2);
   std::unique_ptr<favicon_base::LargeIconResult> result3 =
       large_icon_cache_->GetCachedResult(GURL(kDummyUrl2));
   EXPECT_EQ(false, result3->bitmap.is_valid());
   EXPECT_EQ(expected_result2->fallback_icon_style->background_color,
             result3->fallback_icon_style->background_color);

[pkotwicz, 2016/09/28 03:52:52]

Shouldn't you test is_default_background_color here too?

[sfiera, 2016/09/28 13:15:52]

Done.

 }
 
 }  // namespace