Media Controls: take into consideration high margin on some elements.

third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 713 matching lines @@
         m_muteButton.get(),
         m_volumeSlider.get(),
         m_toggleClosedCaptionsButton.get(),
         m_castButton.get(),
         m_currentTimeDisplay.get(),
         m_durationDisplay.get(),
     };
 
     int usedWidth = 0;
 
-    // Assume that all controls require 48px, unless we can get the computed
+    // Assume that all controls require 32px, unless we can get the computed
     // style for the play button.  Since the play button or overflow is always
     // shown, one of the two buttons should be available the first time we're
     // called after layout.  This will
     // also be the first time we have m_panelWidth!=0, so it won't matter if
     // we get this wrong before that.
-    int minimumWidth = 48;
+    int minimumWidth = 32;
     if (m_playButton->layoutObject() && m_playButton->layoutObject()->style()) {
         const ComputedStyle* style = m_playButton->layoutObject()->style();
         minimumWidth = ceil(style->width().pixels() / style->effectiveZoom());
     } else if (m_overflowMenu->layoutObject() && m_overflowMenu->layoutObject()->style()) {
         const ComputedStyle* style = m_overflowMenu->layoutObject()->style();
         minimumWidth = ceil(style->width().pixels() / style->effectiveZoom());
     }
 
+    // TODO(mlamouri): we need a more dynamic way to find out the width of an
+    // element.
+    int largeMinimumWidth = minimumWidth * 2;

[liberato (no reviews please), 2016/09/27 16:33:53]

is this enough on desktop?  there is 18px margin on either side.

might want +36 rather than *2 -- not sure that we need 48*2 on android.

[mlamouri (slow - plz ping), 2016/09/29 13:00:39]

Done.

+
     if (!m_panelWidth) {
         // No layout yet -- hide everything, then make them show up later.
         // This prevents the wrong controls from being shown briefly
         // immediately after the first layout and paint, but before we have
         // a chance to revise them.
         for (MediaControlElement* element : elements) {
             if (element)
                 element->setDoesFit(false);
         }
         return;
     }
 
     // Insert an overflow menu. However, if we see that the overflow menu
     // doesn't end up containing at least two elements, we will not display it
     // but instead make place for the first element that was dropped.
     m_overflowMenu->setDoesFit(true);
     m_overflowMenu->setIsWanted(true);
     usedWidth = minimumWidth;
 
     std::list<MediaControlElement*> overflowElements;
     MediaControlElement* firstDisplacedElement = nullptr;
     // For each control that fits, enable it in order of decreasing priority.
     bool droppedCastButton = false;
     for (MediaControlElement* element : elements) {
         if (!element)
             continue;
+        int width = minimumWidth;
+        if ((element == m_timeline.get()) || (element == m_volumeSlider.get()))
+            width = largeMinimumWidth;
         element->shouldShowButtonInOverflowMenu(false);
         if (element->isWanted()) {
-            if (usedWidth + minimumWidth <= m_panelWidth) {
+            if (usedWidth + width <= m_panelWidth) {
                 element->setDoesFit(true);
-                usedWidth += minimumWidth;
+                usedWidth += width;
             } else {
                 element->setDoesFit(false);
+                // TODO(mlamouri): we should probably no longer mark the cast
+                // button as dropped, it should appear in the overflow menu.
                 if (element == m_castButton.get())
                     droppedCastButton = true;
                 element->shouldShowButtonInOverflowMenu(true);
                 if (element->hasOverflowButton())
                     overflowElements.push_front(element);
                 // We want a way to access the first media element that was
                 // removed. If we don't end up needing an overflow menu, we can
                 // use the space the overflow menu would have taken up to
                 // instead display that media element.
                 if (!element->hasOverflowButton() && !firstDisplacedElement)
                     firstDisplacedElement = element;
             }
         }
     }
 
     // If we don't have at least two overflow elements, we will not show the
     // overflow menu.
     if (overflowElements.empty()) {
         m_overflowMenu->setIsWanted(false);
-        if (firstDisplacedElement)
-            firstDisplacedElement->setDoesFit(true);
+        usedWidth -= minimumWidth;
+        if (firstDisplacedElement) {
+            int width = minimumWidth;
+            if ((firstDisplacedElement == m_timeline.get()) || (firstDisplacedElement == m_volumeSlider.get()))
+                width = largeMinimumWidth;
+            if (usedWidth + width <= m_panelWidth)
+                firstDisplacedElement->setDoesFit(true);
+        }
     } else if (overflowElements.size() == 1) {
+        LOG(INFO) << "set first element";

[liberato (no reviews please), 2016/09/27 16:33:53]

:)

[mlamouri (slow - plz ping), 2016/09/29 13:00:39]

Done.

         m_overflowMenu->setIsWanted(false);
         overflowElements.front()->setDoesFit(true);
     }
 
     // Special case for cast: if we want a cast button but dropped it, then
     // show the overlay cast button instead.
     if (m_castButton->isWanted()) {
         if (droppedCastButton)
             m_overlayCastButton->tryShowOverlay();
         else
@@ skipping 56 matching lines @@
     visitor->trace(m_enclosure);
     visitor->trace(m_textTrackList);
     visitor->trace(m_overflowMenu);
     visitor->trace(m_overflowList);
     visitor->trace(m_castButton);
     visitor->trace(m_overlayCastButton);
     HTMLDivElement::trace(visitor);
 }
 
 } // namespace blink