Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2374723002: --turbo-cache-shared-code shouldn't control lookup in optimized code map. (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

--turbo-cache-shared-code shouldn't control lookup in optimized code map. This flag is meant to control whether we add a special context-free entry to the optimized code map or not. A usage of the flag was bogus. BUG= Committed: https://crrev.com/7abb0c69fb3fd7fc94101d5161d8e29a24935f88 Cr-Commit-Position: refs/heads/master@{#39784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M src/compiler.cc View 1 chunk +9 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mvstanton
Hi Michael, Here is the change we noticed the other day, thanks for the look! ...
4 years, 2 months ago (2016-09-27 15:19:23 UTC) #6
Michael Starzinger
LGTM. The title of the CL is somewhat misleading, it should read "[...] shouldn't control ...
4 years, 2 months ago (2016-09-27 15:35:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374723002/1
4 years, 2 months ago (2016-09-27 16:36:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 16:44:13 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 16:44:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7abb0c69fb3fd7fc94101d5161d8e29a24935f88
Cr-Commit-Position: refs/heads/master@{#39784}

Powered by Google App Engine
This is Rietveld 408576698