Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2374703002: [stubs] remove unused BranchIfSameValueZero from CodeStubAssembler (Closed)

Created:
4 years, 2 months ago by caitp
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] remove unused BranchIfSameValueZero from CodeStubAssembler BUG=v8:5268, v8:5162 R=ishell@chromium.org Committed: https://crrev.com/ccdfa302ba179cbd9faf6190a0eeabe08f4ad5c6 Cr-Commit-Position: refs/heads/master@{#39766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -78 lines) Patch
M src/code-stub-assembler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +0 lines, -74 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
caitp
Hey, PTAL --- some dead code removal per https://codereview.chromium.org/2205883003/#msg19
4 years, 2 months ago (2016-09-27 11:48:08 UTC) #1
Igor Sheludko
lgtm. Thanks!
4 years, 2 months ago (2016-09-27 11:56:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374703002/1
4 years, 2 months ago (2016-09-27 12:32:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 12:34:33 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 12:34:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccdfa302ba179cbd9faf6190a0eeabe08f4ad5c6
Cr-Commit-Position: refs/heads/master@{#39766}

Powered by Google App Engine
This is Rietveld 408576698