Issue 23747003: Wire up profiling budget to the Code object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23747003: Wire up profiling budget to the Code object. (Closed)

Created:
7 years, 3 months ago by Yang

Modified:
7 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Wire up profiling budget to the Code object. R=jkummerow@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -15 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/full-codegen.h	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	src/full-codegen.cc	View	2 chunks	+6 lines, -0 lines	1 comment	Download
M	src/ia32/full-codegen-ia32.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

7 years, 3 months ago (2013-08-30 11:13:39 UTC) #2

High-level:

(1) I'd prefer this extra field to be in the SharedFunctionInfo, as we have many
Code objects that don't need it, and Code object header size is fairly sensitive
as the entry offset must be aligned (at least 16-byte, I think).

(2) Shouldn't we call the thing interrupt_budget?

https://codereview.chromium.org/23747003/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):

https://codereview.chromium.org/23747003/diff/1/src/full-codegen.cc#newcode439
src/full-codegen.cc:439: ASSERT(!profiling_budget_.is_null());
No need for this ASSERT, you get it for free as part of the deref below.

Expand Messages | Collapse Messages