Use WmLayoutManager::OnChildWindowVisibilityChanged to update the system modal state.

Use WmLayoutManager::OnChildWindowVisibilityChanged to update the system modal state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in

https://codereview.chromium.org/2369413002/

but it's probably better to use WmLayoutManager::OnChildWindowVisibilityChanged because it's WmLayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.

Committed: https://crrev.com/a1246e525e255367df004c528c93009fefb645e0
Cr-Commit-Position: refs/heads/master@{#421558}

[oshima, 2016-09-27 18:19:24]

Patchset #1 (id:1) has been deleted

[oshima, 2016-09-27 18:19:28]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 18:19:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-09-27 18:43:08]

Description was changed from

==========
Observe WmLayoutManager::OnChildWindowVisibilityChanged to update the systemo
modal state.

WmWindowObserver::OnChildWindowVisibility's 1st argument is now always receiver,
and can be called multiple times with the same visibility state. That's causing
the issue
where the window is added to the modal window list multiple times.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

to

==========
Observe WmLayoutManager::OnChildWindowVisibilityChanged to update the systemo
modal state.

WmWindowObserver::OnChildWindowVisibility's 1st argument is now always receiver,
and can be called multiple times with the same visibility state. That's causing
the issue
where the window is added to the modal window list multiple times.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

[oshima, 2016-09-27 18:43:08]

oshima@chromium.org changed reviewers:
+ lpique@chromium.org, sky@chromium.org

[oshima, 2016-09-27 18:44:19]

Description was changed from

==========
Observe WmLayoutManager::OnChildWindowVisibilityChanged to update the systemo
modal state.

WmWindowObserver::OnChildWindowVisibility's 1st argument is now always receiver,
and can be called multiple times with the same visibility state. That's causing
the issue
where the window is added to the modal window list multiple times.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

to

==========
Use WmLayoutManager::OnChildWindowVisibilityChanged to update the systemo modal
state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in 

https://codereview.chromium.org/2369413002/

but WmLayoutManager::OnChildWindowVisibilityChanged is better API because it's
LayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

[oshima, 2016-09-27 18:44:59]

Description was changed from

==========
Use WmLayoutManager::OnChildWindowVisibilityChanged to update the systemo modal
state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in 

https://codereview.chromium.org/2369413002/

but WmLayoutManager::OnChildWindowVisibilityChanged is better API because it's
LayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

to

==========
Use WmLayoutManager::OnChildWindowVisibilityChanged to update the systemo modal
state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in 

https://codereview.chromium.org/2369413002/

but WmLayoutManager::OnChildWindowVisibilityChanged is better API because it's
WmLayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

[oshima, 2016-09-27 18:45:14]

Description was changed from

==========
Use WmLayoutManager::OnChildWindowVisibilityChanged to update the systemo modal
state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in 

https://codereview.chromium.org/2369413002/

but WmLayoutManager::OnChildWindowVisibilityChanged is better API because it's
WmLayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

to

==========
Use WmLayoutManager::OnChildWindowVisibilityChanged to update the system modal
state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in 

https://codereview.chromium.org/2369413002/

but WmLayoutManager::OnChildWindowVisibilityChanged is better API because it's
WmLayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

[oshima, 2016-09-27 18:45:40]

Description was changed from

==========
Use WmLayoutManager::OnChildWindowVisibilityChanged to update the system modal
state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in 

https://codereview.chromium.org/2369413002/

but WmLayoutManager::OnChildWindowVisibilityChanged is better API because it's
WmLayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

to

==========
Use WmLayoutManager::OnChildWindowVisibilityChanged to update the system modal
state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in 

https://codereview.chromium.org/2369413002/

but it's probably better to use WmLayoutManager::OnChildWindowVisibilityChanged
because it's WmLayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

[commit-bot: I haz the power, 2016-09-27 18:48:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 18:48:44]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-27 22:10:58]

LGTM

https://codereview.chromium.org/2374613004/diff/20001/ash/wm/system_modal_con...
File ash/wm/system_modal_container_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2374613004/diff/20001/ash/wm/system_modal_con...
ash/wm/system_modal_container_layout_manager_unittest.cc:789:
std::unique_ptr<aura::Window> child(new aura::Window(nullptr));
MakeUnique rather than new.

[oshima, 2016-09-28 14:26:00]

https://codereview.chromium.org/2374613004/diff/20001/ash/wm/system_modal_con...
File ash/wm/system_modal_container_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2374613004/diff/20001/ash/wm/system_modal_con...
ash/wm/system_modal_container_layout_manager_unittest.cc:789:
std::unique_ptr<aura::Window> child(new aura::Window(nullptr));
On 2016/09/27 22:10:57, sky wrote:
> MakeUnique rather than new.

Done.

[oshima, 2016-09-28 17:03:30]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-09-28 17:03:30]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2374613004/#ps40001
(title: "Observe WmLayoutManager::OnChildWindowVisibilityChanged to update the
systemo modal state.")

[commit-bot: I haz the power, 2016-09-28 17:03:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 17:31:37]

Description was changed from

==========
Use WmLayoutManager::OnChildWindowVisibilityChanged to update the system modal
state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in 

https://codereview.chromium.org/2369413002/

but it's probably better to use WmLayoutManager::OnChildWindowVisibilityChanged
because it's WmLayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

to

==========
Use WmLayoutManager::OnChildWindowVisibilityChanged to update the system modal
state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in 

https://codereview.chromium.org/2369413002/

but it's probably better to use WmLayoutManager::OnChildWindowVisibilityChanged
because it's WmLayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

[commit-bot: I haz the power, 2016-09-28 17:31:38]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-28 17:34:40]

Description was changed from

==========
Use WmLayoutManager::OnChildWindowVisibilityChanged to update the system modal
state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in 

https://codereview.chromium.org/2369413002/

but it's probably better to use WmLayoutManager::OnChildWindowVisibilityChanged
because it's WmLayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.
==========

to

==========
Use WmLayoutManager::OnChildWindowVisibilityChanged to update the system modal
state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in

https://codereview.chromium.org/2369413002/

but it's probably better to use WmLayoutManager::OnChildWindowVisibilityChanged
because it's WmLayoutManager.

BUG=crbug.com/650751
TEST=covered by unit tests. tested manulally with the test app in the bug.

Committed: https://crrev.com/a1246e525e255367df004c528c93009fefb645e0
Cr-Commit-Position: refs/heads/master@{#421558}
==========

[commit-bot: I haz the power, 2016-09-28 17:34:41]

Patchset 2 (id:??) landed as
https://crrev.com/a1246e525e255367df004c528c93009fefb645e0
Cr-Commit-Position: refs/heads/master@{#421558}