Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2374603003: [stubs] Add a test for canary crashes in SubStringStub (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Benedikt Meurer, Igor Sheludko
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Add a test for canary crashes in SubStringStub These crashes were caused by an invalid pointer stored in a tagged variable in SubStringStub. This can be reproduced by calling the stub on an external string and ensuring GC kicks in on the subsequent allocation. Only the TurboFan implementation of SubStringStub is affected, the current PlatformStub implementation handles this case just fine. BUG=chromium:649967 Committed: https://crrev.com/0ce95e0878f89b53029f39ad22e90d9413d9005f Cr-Commit-Position: refs/heads/master@{#39772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M test/cctest/test-strings.cc View 2 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jgruber
4 years, 2 months ago (2016-09-27 12:59:28 UTC) #6
Jarin
lgtm
4 years, 2 months ago (2016-09-27 13:41:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374603003/1
4 years, 2 months ago (2016-09-27 13:48:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 13:53:06 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 13:53:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ce95e0878f89b53029f39ad22e90d9413d9005f
Cr-Commit-Position: refs/heads/master@{#39772}

Powered by Google App Engine
This is Rietveld 408576698