Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/extensions-test.js

Issue 2374573002: DevTools: remove extra indirections from how extension API is built (Closed)
Patch Set: pass null instead of -1 when tab is not defined Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector/extensions-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/extensions-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/extensions-test.js
index 29bcfbe8c9a0a01a61488cd47157e32e5c5899da..cf84c359c2433d19905fdc3c2910e0523c1f009d 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/extensions-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/extensions-test.js
@@ -11,18 +11,13 @@ function extensionFunctions()
var initialize_ExtensionsTest = function()
{
+WebInspector.extensionServer._registerHandler("evaluateForTestInFrontEnd", onEvaluate);
-WebInspector.extensionServer._overridePlatformExtensionAPIForTest = function(extensionInfo, inspectedTabId, themeName)
+WebInspector.extensionServer._extensionAPITestHook = function(extensionServerClient, coreAPI)
{
- WebInspector.extensionServer._registerHandler("evaluateForTestInFrontEnd", onEvaluate);
-
- function platformExtensionAPI(coreAPI)
- {
- window.webInspector = coreAPI;
- window._extensionServerForTests = extensionServer;
- coreAPI.panels.themeName = "themeNameForTest";
- }
- return platformExtensionAPI.toString();
+ window.webInspector = coreAPI;
+ window._extensionServerForTests = extensionServerClient;
+ coreAPI.panels.themeName = "themeNameForTest";
}
InspectorTest._replyToExtension = function(requestId, port)
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698