Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2374573002: DevTools: remove extra indirections from how extension API is built (Closed)

Created:
4 years, 2 months ago by caseq
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove extra indirections from how extension API is built This removes platform-specific hooks from extension API generation, as these were only relevant in WebKit. Committed: https://crrev.com/f0be7c342e155bfffb8c832e85668c6c9a192336 Cr-Commit-Position: refs/heads/master@{#421301}

Patch Set 1 #

Patch Set 2 : pass null instead of -1 when tab is not defined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -74 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/extensions-test.js View 1 chunk +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js View 1 3 chunks +48 lines, -63 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
caseq
4 years, 2 months ago (2016-09-26 22:09:42 UTC) #2
dgozman
lgtm
4 years, 2 months ago (2016-09-27 16:47:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374573002/20001
4 years, 2 months ago (2016-09-27 17:55:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 19:44:26 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 19:46:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0be7c342e155bfffb8c832e85668c6c9a192336
Cr-Commit-Position: refs/heads/master@{#421301}

Powered by Google App Engine
This is Rietveld 408576698