Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

Issue 2374543005: Set close_fds True in Popen of cloudtail (Closed)
Patch Set: use devnull for stdout/stderr of cloudtail Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py
diff --git a/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py b/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py
index 45ec1556582c9ba8f9ad0a82115b99b8e1a73fe3..ea3c619976c857f27e66c2cefcae7b6e454e78dc 100644
--- a/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py
+++ b/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py
@@ -20,7 +20,10 @@ def start_cloudtail(args):
'tail',
'--log-id', 'goma_compiler_proxy',
'--path',
- goma_utils.GetLatestGomaCompilerProxyInfo()])
+ goma_utils.GetLatestGomaCompilerProxyInfo()],
+ stdout=open(os.devnull, 'w'),
+ stderr=open(os.devnull, 'w'),
+ close_fds=True)
sys.stdout.write(str(proc.pid))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698