scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py - Issue 2374543005: Set close_fds True in Popen of cloudtail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

Issue 2374543005: Set close_fds True in Popen of cloudtail (Closed)

Patch Set: use devnull for stdout/stderr of cloudtail Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

diff --git a/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py b/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

index 45ec1556582c9ba8f9ad0a82115b99b8e1a73fe3..ea3c619976c857f27e66c2cefcae7b6e454e78dc 100644

--- a/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

+++ b/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

@@ -20,7 +20,10 @@ def start_cloudtail(args):

'tail',

'--log-id', 'goma_compiler_proxy',

'--path',

- goma_utils.GetLatestGomaCompilerProxyInfo()])

+ goma_utils.GetLatestGomaCompilerProxyInfo()],

+ stdout=open(os.devnull, 'w'),

+ stderr=open(os.devnull, 'w'),

+ close_fds=True)

sys.stdout.write(str(proc.pid))

« no previous file with comments | « no previous file | no next file » | no next file with comments »