ui/devtools/StringUtil.cc - Issue 2374513002: Add ui devtools server

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/devtools/StringUtil.cc

Issue 2374513002: Add ui devtools server (Closed)

Patch Set: Initial commit for ui devtools server Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/devtools/StringUtil.h"

	6

	7 #include "ui/devtools/Protocol.h"

	8

	9 namespace ui {

	10 namespace devtools {

	11 namespace protocol {

	12

	13 std::unique_ptr<Value> parseJSON(const String& string) {

	14 return parseJSON(reinterpret_cast<const uint8_t*>(&string[0]),
	sadrul 2016/10/17 16:05:08 Hm, we probably need to check that this is safe. H Hm, we probably need to check that this is safe. How about a DCHECK(base::IsStringUTF8(string)) before doing this? And a TODO to work correctly for 16-bit strings too. Sarmad Hashmi 2016/10/17 16:58:21 Done. Show quoted text On 2016/10/17 16:05:08, sadrul wrote: > Hm, we probably need to check that this is safe. How about a > DCHECK(base::IsStringUTF8(string)) before doing this? And a TODO to work > correctly for 16-bit strings too. Done.
	15 string.length());

	16 };

	17

	18 } // namespace protocol

	19 } // namespace ws

	20 } // namespace ui

OLD	NEW