runtime/vm/stub_code_ia32.cc - Issue 23745008: Follow-up fix to my change to IsPowerOfTwo: Alignment of one means no alignment, not zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 23745008: Follow-up fix to my change to IsPowerOfTwo: Alignment of one means no alignment, not zero. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_ia32.cc

===================================================================

--- runtime/vm/stub_code_ia32.cc (revision 27015)

+++ runtime/vm/stub_code_ia32.cc (working copy)

@@ -59,7 +59,7 @@

// Reserve space for arguments and align frame before entering C++ world.

__ AddImmediate(ESP, Immediate(-sizeof(NativeArguments)));

- if (OS::ActivationFrameAlignment() > 0) {

+ if (OS::ActivationFrameAlignment() > 1) {

__ andl(ESP, Immediate(~(OS::ActivationFrameAlignment() - 1)));

}

@@ -151,7 +151,7 @@

// (pointer to the native arguments structure, the C function entry point)

// and align frame before entering the C++ world.

__ AddImmediate(ESP, Immediate(-sizeof(NativeArguments) - (2 * kWordSize)));

- if (OS::ActivationFrameAlignment() > 0) {

+ if (OS::ActivationFrameAlignment() > 1) {

__ andl(ESP, Immediate(~(OS::ActivationFrameAlignment() - 1)));

}

@@ -222,7 +222,7 @@

// (pointer to the native arguments structure) and align frame before

// entering the C++ world.

__ AddImmediate(ESP, Immediate(-sizeof(NativeArguments) - kWordSize));

- if (OS::ActivationFrameAlignment() > 0) {

+ if (OS::ActivationFrameAlignment() > 1) {

__ andl(ESP, Immediate(~(OS::ActivationFrameAlignment() - 1)));

}

« no previous file with comments | « runtime/vm/simulator_mips.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »