Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: runtime/vm/os_win.cc

Issue 23745008: Follow-up fix to my change to IsPowerOfTwo: Alignment of one means no alignment, not zero. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/os.h ('k') | runtime/vm/simulator_arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_OS_WINDOWS) 6 #if defined(TARGET_OS_WINDOWS)
7 7
8 #include "vm/os.h" 8 #include "vm/os.h"
9 #include "vm/vtune.h" 9 #include "vm/vtune.h"
10 10
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 _aligned_free(ptr); 129 _aligned_free(ptr);
130 } 130 }
131 131
132 132
133 word OS::ActivationFrameAlignment() { 133 word OS::ActivationFrameAlignment() {
134 #ifdef _WIN64 134 #ifdef _WIN64
135 // Windows 64-bit ABI requires the stack to be 16-byte aligned. 135 // Windows 64-bit ABI requires the stack to be 16-byte aligned.
136 return 16; 136 return 16;
137 #else 137 #else
138 // No requirements on Win32. 138 // No requirements on Win32.
139 return 0; 139 return 1;
140 #endif 140 #endif
141 } 141 }
142 142
143 143
144 word OS::PreferredCodeAlignment() { 144 word OS::PreferredCodeAlignment() {
145 ASSERT(32 <= OS::kMaxPreferredCodeAlignment); 145 ASSERT(32 <= OS::kMaxPreferredCodeAlignment);
146 return 32; 146 return 32;
147 } 147 }
148 148
149 149
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 } 311 }
312 312
313 313
314 void OS::Exit(int code) { 314 void OS::Exit(int code) {
315 exit(code); 315 exit(code);
316 } 316 }
317 317
318 } // namespace dart 318 } // namespace dart
319 319
320 #endif // defined(TARGET_OS_WINDOWS) 320 #endif // defined(TARGET_OS_WINDOWS)
OLDNEW
« no previous file with comments | « runtime/vm/os.h ('k') | runtime/vm/simulator_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698