Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2374453002: Tools not running from snapshots should use /.packages (Closed)

Created:
4 years, 2 months ago by Bill Hesse
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tools not running from snapshots should use /.packages Stray .package files in their source can otherwise cause errors. BUG= R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9941b665bfa643f3639e76ae39a7af2afa129374

Patch Set 1 #

Patch Set 2 : DART_ROOT doesn't exist in pub scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M sdk/bin/dart2js View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dart2js.bat View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartanalyzer View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartanalyzer.bat View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartdevc View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartdevc.bat View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartfmt View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartfmt.bat View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/pub View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/pub.bat View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Bill Hesse
4 years, 2 months ago (2016-09-26 16:31:20 UTC) #2
Bill Hesse
4 years, 2 months ago (2016-09-26 16:34:45 UTC) #4
scheglov
lgtm
4 years, 2 months ago (2016-09-26 16:45:31 UTC) #5
Paul Berry
lgtm
4 years, 2 months ago (2016-09-26 16:46:26 UTC) #6
Bill Hesse
Committed patchset #2 (id:20001) manually as 9941b665bfa643f3639e76ae39a7af2afa129374 (presubmit successful).
4 years, 2 months ago (2016-09-26 16:47:39 UTC) #8
Harry Terkelsen
4 years, 2 months ago (2016-09-26 17:03:33 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698