Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2374413002: Move core/fdrm/crypto/include to core/fdrm/crypto (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move core/fdrm/crypto/include to core/fdrm/crypto BUG=pdfium:611 Committed: https://pdfium.googlesource.com/pdfium/+/b1469a2c89d338c7fc3e9029405c8bc7e1018b84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -85 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + core/fdrm/crypto/fx_crypt.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fdrm/crypto/fx_crypt.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fdrm/crypto/fx_crypt_aes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fdrm/crypto/fx_crypt_sha.cpp View 1 chunk +1 line, -1 line 0 comments Download
D core/fdrm/crypto/include/fx_crypt.h View 1 chunk +0 lines, -71 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_crypto_handler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_security_handler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_GlobalData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_checksum.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 13:56:31 UTC) #4
Lei Zhang
So we are just not going to worry about "public" vs "internal" headers at the ...
4 years, 2 months ago (2016-09-29 15:35:34 UTC) #7
dsinclair
On 2016/09/29 15:35:34, Lei Zhang wrote: > So we are just not going to worry ...
4 years, 2 months ago (2016-09-29 15:38:57 UTC) #8
Lei Zhang
If we are not worried about internal boundaries as much, other than those between top ...
4 years, 2 months ago (2016-09-29 16:46:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374413002/1
4 years, 2 months ago (2016-09-29 16:59:50 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 17:00:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/b1469a2c89d338c7fc3e9029405c8bc7e101...

Powered by Google App Engine
This is Rietveld 408576698