Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2374353002: Revert "Revert of ServiceWorker: Implement StartWorker by using mojo (patchset #1 id:1 of https://c… (Closed)

Created:
4 years, 2 months ago by shimazu
Modified:
3 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, tzik, jam, abarth-chromium, darin-cc_chromium.org, blink-reviews, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nhiroki, michaeln, shimazu+serviceworker_chromium.org, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, horo+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of ServiceWorker: Implement StartWorker by using mojo (patchset #1 id:1 of https://codereview.chromium.org/2378073002/ )" This reverts commit e0efe32458df38eae4ed49d94f6772281dd46702. Reason for revert: This patch actually does not cause Leak. It was already tracked by another issue: crbug.com/506754 TBR=horo@chromium.org,mek@chromium.org,dcheng@chromium.org,falken@chromium.org,avi@chromium.org BUG=629701, 506754, 650955 Committed: https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea Cr-Commit-Position: refs/heads/master@{#421780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -142 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.h View 6 chunks +10 lines, -3 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 14 chunks +55 lines, -26 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 20 chunks +59 lines, -20 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.h View 5 chunks +11 lines, -6 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.cc View 2 chunks +17 lines, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 7 chunks +45 lines, -5 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 5 chunks +78 lines, -11 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A content/common/service_worker/embedded_worker.mojom View 1 chunk +16 lines, -0 lines 0 comments Download
A content/common/service_worker/embedded_worker.typemap View 1 chunk +10 lines, -0 lines 0 comments Download
M content/common/service_worker/embedded_worker_messages.h View 3 chunks +13 lines, -12 lines 0 comments Download
A content/common/service_worker/embedded_worker_start_params.h View 1 chunk +30 lines, -0 lines 0 comments Download
A + content/common/service_worker/embedded_worker_start_params.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/common/service_worker/service_worker_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_utils.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/common/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/app/mojo/content_renderer_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.h View 2 chunks +36 lines, -3 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.cc View 4 chunks +47 lines, -44 lines 0 comments Download
A content/renderer/service_worker/embedded_worker_instance_client_impl.h View 1 chunk +38 lines, -0 lines 0 comments Download
A content/renderer/service_worker/embedded_worker_instance_client_impl.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/LeakExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/mojo-service-worker/http/tests/serviceworker/README.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374353002/1
4 years, 2 months ago (2016-09-29 05:33:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 08:45:49 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 08:48:24 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea
Cr-Commit-Position: refs/heads/master@{#421780}

Powered by Google App Engine
This is Rietveld 408576698