Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2374293002: Clean up printing/emf_win.cc. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up printing/emf_win.cc. And printing/printing_context_win.*. Committed: https://crrev.com/b50a0c339ec774bb9cfc213eb0900634ca289e4f Cr-Commit-Position: refs/heads/master@{#422027}

Patch Set 1 #

Patch Set 2 : build #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -63 lines) Patch
M printing/emf_win.cc View 1 16 chunks +35 lines, -43 lines 0 comments Download
M printing/printing_context_win.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M printing/printing_context_win.cc View 1 8 chunks +17 lines, -18 lines 2 comments Download

Messages

Total messages: 19 (13 generated)
Lei Zhang
4 years, 2 months ago (2016-09-29 23:28:08 UTC) #10
dcheng
LGTM https://codereview.chromium.org/2374293002/diff/20001/printing/printing_context_win.cc File printing/printing_context_win.cc (right): https://codereview.chromium.org/2374293002/diff/20001/printing/printing_context_win.cc#newcode366 printing/printing_context_win.cc:366: // TODO(maruel): b/1214347 Get the right browser window ...
4 years, 2 months ago (2016-09-30 02:38:40 UTC) #11
Lei Zhang
https://codereview.chromium.org/2374293002/diff/20001/printing/printing_context_win.cc File printing/printing_context_win.cc (right): https://codereview.chromium.org/2374293002/diff/20001/printing/printing_context_win.cc#newcode366 printing/printing_context_win.cc:366: // TODO(maruel): b/1214347 Get the right browser window instead. ...
4 years, 2 months ago (2016-09-30 04:16:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374293002/20001
4 years, 2 months ago (2016-09-30 04:17:19 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 04:23:08 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 04:28:06 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b50a0c339ec774bb9cfc213eb0900634ca289e4f
Cr-Commit-Position: refs/heads/master@{#422027}

Powered by Google App Engine
This is Rietveld 408576698