Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2374253008: [build] Landmine to fix windows build problems (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Landmine to fix windows build problems TBR=jochen@chromium.org, neis@chromium.org NOTRY=true Committed: https://crrev.com/96c25e58243de40d2030750e62197f242eb8a27e Cr-Commit-Position: refs/heads/master@{#39898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gypfiles/get_landmines.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Michael Achenbach
PTAL. Some of our builders produce some messed up executables, while others seem to be ...
4 years, 2 months ago (2016-09-30 07:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374253008/1
4 years, 2 months ago (2016-09-30 07:08:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 07:11:16 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 07:11:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96c25e58243de40d2030750e62197f242eb8a27e
Cr-Commit-Position: refs/heads/master@{#39898}

Powered by Google App Engine
This is Rietveld 408576698