Report unpermitted interface requests as bad messages

Report unpermitted interface requests as bad messages

In practice this will result in the browser shooting any
renderer which asks for an interface it's not allowed to have.

This also adds a browser manifest overlay for chromecast.

BUG=None
R=ben@chromium.org

Committed: https://crrev.com/97597159c2bdd0a378fca56750e1bc1a1defe7ed
Cr-Commit-Position: refs/heads/master@{#422377}

[Ken Rockot(use gerrit already), 2016-09-30 00:06:03]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 00:06:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 00:36:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 00:36:01]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ben Goodger (Google), 2016-09-30 20:02:54]

lgtm

[Ken Rockot(use gerrit already), 2016-09-30 20:25:12]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 20:25:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-09-30 20:37:19]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-09-30 20:37:29]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-09-30 20:37:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-09-30 20:39:37]

rockot@chromium.org changed reviewers:
+ alokp@chromium.org

[Ken Rockot(use gerrit already), 2016-09-30 20:39:38]

+alokp for chromecast/

Note that normally we'd have an overlay json resource to simply parse and return
here (see Chome/Blimp/ShellContentBrowserClient examples), but I didn't want to
add a resource pak for chromecast when there wasn't one already, so I've just
inlined the overlay for now. Please take a look!

[Ken Rockot(use gerrit already), 2016-09-30 20:40:15]

On 2016/09/30 at 20:39:38, Ken Rockot wrote:
> +alokp for chromecast/
> 
> Note that normally we'd have an overlay json resource to simply parse and
return here (see Chome/Blimp/ShellContentBrowserClient examples), but I didn't
want to add a resource pak for chromecast when there wasn't one already, so I've
just inlined the overlay for now. Please take a look!

Note that previously we were simply logging an error message and the renderer
would silently fail to get the MediaCaps interface.

[commit-bot: I haz the power, 2016-09-30 20:59:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 20:59:21]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ken Rockot(use gerrit already), 2016-09-30 21:24:40]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-09-30 21:24:47]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-09-30 21:25:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-09-30 21:29:12]

Description was changed from

==========
Report unpermitted interface requests as bad messages

In practice this will result in the browser shooting any
renderer which asks for an interface it's not allowed to have.

BUG=None
R=ben@chromium.org
==========

to

==========
Report unpermitted interface requests as bad messages

In practice this will result in the browser shooting any
renderer which asks for an interface it's not allowed to have.

This also adds a browser manifest overlay for chromecast.

BUG=None
R=ben@chromium.org
==========

[commit-bot: I haz the power, 2016-09-30 22:13:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 22:13:02]

Dry run: This issue passed the CQ dry run.

[alokp, 2016-09-30 22:51:16]

On 2016/09/30 20:39:38, Ken Rockot wrote:
> +alokp for chromecast/
> 
> Note that normally we'd have an overlay json resource to simply parse and
return
> here (see Chome/Blimp/ShellContentBrowserClient examples), but I didn't want
to
> add a resource pak for chromecast when there wasn't one already, so I've just
> inlined the overlay for now. Please take a look!

We do have a resource pak but it does not include any mojo manifest yet. Would
you mind adding a TODO(alokp)?

[alokp, 2016-09-30 22:51:22]

lgtm

[Ken Rockot(use gerrit already), 2016-09-30 22:59:24]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 22:59:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-09-30 23:48:29]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 23:49:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-09-30 23:49:45]

rockot@chromium.org changed reviewers:
+ thestig@chromium.org

[Ken Rockot(use gerrit already), 2016-09-30 23:49:45]

Oh, didn't notice cast_shell_pak somehow. I just went ahead and added the
resource. Please take another look.

+thestig@ for grit OWNERS

[Lei Zhang, 2016-09-30 23:51:03]

lgtm

[commit-bot: I haz the power, 2016-09-30 23:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 23:57:56]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alokp, 2016-10-01 00:00:31]

Thanks!

still lgtm

[Ken Rockot(use gerrit already), 2016-10-03 04:43:42]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 04:43:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 04:50:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 04:50:26]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Ken Rockot(use gerrit already), 2016-10-03 05:05:46]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 05:05:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 05:55:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 05:55:16]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-10-03 06:23:01]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-10-03 06:23:01]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
thestig@chromium.org, alokp@chromium.org
Link to the patchset: https://codereview.chromium.org/2374253007/#ps140001
(title: ".")

[commit-bot: I haz the power, 2016-10-03 06:23:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 06:27:57]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-10-03 06:29:27]

Description was changed from

==========
Report unpermitted interface requests as bad messages

In practice this will result in the browser shooting any
renderer which asks for an interface it's not allowed to have.

This also adds a browser manifest overlay for chromecast.

BUG=None
R=ben@chromium.org
==========

to

==========
Report unpermitted interface requests as bad messages

In practice this will result in the browser shooting any
renderer which asks for an interface it's not allowed to have.

This also adds a browser manifest overlay for chromecast.

BUG=None
R=ben@chromium.org

Committed: https://crrev.com/97597159c2bdd0a378fca56750e1bc1a1defe7ed
Cr-Commit-Position: refs/heads/master@{#422377}
==========

[commit-bot: I haz the power, 2016-10-03 06:29:29]

Patchset 6 (id:??) landed as
https://crrev.com/97597159c2bdd0a378fca56750e1bc1a1defe7ed
Cr-Commit-Position: refs/heads/master@{#422377}