Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2374253003: Revert of [heap] Remove border page (Closed)

Created:
4 years, 2 months ago by Michael Lippautz
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Remove border page (patchset #10 id:260001 of https://codereview.chromium.org/2209583002/ ) Reason for revert: No real improvement as we still lack the ability to promote from scavenges/young gen GCs. Let's keep this in mind for later. Original issue's description: > [heap] Remove border page > > A page now belongs either the nursery *or* the intermediate gen. The page that > contained objects of both spaces is removed in this change. > > BUG=chromium:636331 > > Committed: https://crrev.com/42ece47446f0dbd3779d6e0e00dce97a1931a9f9 > Cr-Commit-Position: refs/heads/master@{#39778} TBR=ulan@chromium.org,hpayer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:636331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -112 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/heap/heap-inl.h View 3 chunks +15 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M src/heap/spaces.h View 11 chunks +50 lines, -25 lines 0 comments Download
M src/heap/spaces.cc View 6 chunks +18 lines, -46 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +0 lines, -16 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Lippautz
Created Revert of [heap] Remove border page
4 years, 2 months ago (2016-09-29 08:24:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374253003/1
4 years, 2 months ago (2016-09-29 08:24:10 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 08:25:40 UTC) #5
Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25284)

Powered by Google App Engine
This is Rietveld 408576698