chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc - Issue 2374253002: Fix bookmark bubble/star view highlighting for Harmony.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc

Issue 2374253002: Fix bookmark bubble/star view highlighting for Harmony. (Closed)

Patch Set: fix tests, move bubble creation to toolbar Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/keyboard_access_browsertest.cc ('k') | chrome/browser/ui/views/location_bar/star_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc b/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc

index dab3fc0ba41de05a06ba71073e50d78a8d789067..83d8aafb8e002df6ce18e1b82843cc472537dcdc 100644

--- a/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc

+++ b/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc

@@ -21,7 +21,7 @@ typedef InProcessBrowserTest LocationIconViewTest;

IN_PROC_BROWSER_TEST_F(LocationIconViewTest, HideOnSecondClick) {

BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser());

views::View* location_icon_view =

- browser_view->GetToolbarView()->location_bar()->location_icon_view();

+ browser_view->toolbar()->location_bar()->location_icon_view();

ASSERT_TRUE(location_icon_view);

// Verify that clicking once shows the location icon bubble.