Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3107)

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 2374253002: Fix bookmark bubble/star view highlighting for Harmony. (Closed)
Patch Set: fix tests, move bubble creation to toolbar Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
index 217db73ae8125f2eaad8b696d63117c4ccd5412f..85331a2314e33042bda8588e73a22e6ae9e7ca33 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
@@ -123,7 +123,7 @@ void ExtensionInstalledBubbleView::UpdateAnchorView() {
switch (controller_->anchor_position()) {
case ExtensionInstalledBubble::ANCHOR_BROWSER_ACTION: {
BrowserActionsContainer* container =
- browser_view->GetToolbarView()->browser_actions();
+ browser_view->toolbar()->browser_actions();
// Hitting this DCHECK means |ShouldShow| failed.
DCHECK(!container->animating());
@@ -152,7 +152,7 @@ void ExtensionInstalledBubbleView::UpdateAnchorView() {
// Default case.
if (!reference_view || !reference_view->visible())
- reference_view = browser_view->GetToolbarView()->app_menu_button();
+ reference_view = browser_view->toolbar()->app_menu_button();
SetAnchorView(reference_view);
}
@@ -349,7 +349,7 @@ bool ExtensionInstalledBubble::ShouldShow() {
if (anchor_position() == ANCHOR_BROWSER_ACTION) {
BrowserActionsContainer* container =
BrowserView::GetBrowserViewForBrowser(browser())
- ->GetToolbarView()
+ ->toolbar()
->browser_actions();
return !container->animating();
}
« no previous file with comments | « chrome/browser/ui/views/extensions/bookmark_override_browsertest.cc ('k') | chrome/browser/ui/views/frame/browser_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698