components/sync/engine/events/configure_get_updates_request_event.cc - Issue 2374223003: Sync MDP: reimplement value conversions ontop of visitors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine/events/configure_get_updates_request_event.cc

Issue 2374223003: Sync MDP: reimplement value conversions ontop of visitors

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/engine/cycle/sync_cycle_snapshot.cc ('k') | components/sync/protocol/proto_compare_value_conversions_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/engine/events/configure_get_updates_request_event.cc

diff --git a/components/sync/engine/events/configure_get_updates_request_event.cc b/components/sync/engine/events/configure_get_updates_request_event.cc

index 5ff5c83b5ee375aeae2cc3102a7b7c3fa66c19d7..a709c0235488dbe9087819001b0f13df494d58f1 100644

--- a/components/sync/engine/events/configure_get_updates_request_event.cc

+++ b/components/sync/engine/events/configure_get_updates_request_event.cc

@@ -27,7 +27,7 @@ std::string ConfigureGetUpdatesRequestEvent::GetType() const {

}

std::string ConfigureGetUpdatesRequestEvent::GetDetails() const {

- return base::StringPrintf("Reason: %s", GetUpdatesOriginString(origin_));

+ return base::StringPrintf("Reason: %s", ProtoEnumToString(origin_));

}

std::unique_ptr<base::DictionaryValue>