Refactored static_cast'ing of events to use the AsXXXEvent() methods.

ui/events/event.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/event.h"
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 
@@ skipping 270 matching lines @@
          AsPointerEvent()->pointer_details().pointer_type ==
              EventPointerType::POINTER_TYPE_MOUSE;
 }
 
 bool Event::IsTouchPointerEvent() const {
   return IsPointerEvent() &&
          AsPointerEvent()->pointer_details().pointer_type ==
              EventPointerType::POINTER_TYPE_TOUCH;
 }
 
+CancelModeEvent* Event::AsCancelModeEvent() {

[rjkroege, 2016/10/03 22:58:40]

I know that you're (rightly) following the pattern of the other As* methods but
I'm unhappy that these aren't inlined. A function call is a lot slower than a
compile time cast. Can these all of this methods be converted to DCHECK and be
sure to be inlined in a future CL?

[sadrul, 2016/10/04 00:35:04]

+1

[kylix_rd, 2016/10/04 14:12:20]

Certainly. I can simply move the method bodies to the header and the compiler
should use that as a hint to inline, right? I can also add 'inline' to the decl
to be sure.

+  CHECK(IsCancelModeEvent());
+  return static_cast<CancelModeEvent*>(this);
+}
+
+const CancelModeEvent* Event::AsCancelModeEvent() const {
+  CHECK(IsCancelModeEvent());
+  return static_cast<const CancelModeEvent*>(this);
+}
+
 GestureEvent* Event::AsGestureEvent() {
   CHECK(IsGestureEvent());
   return static_cast<GestureEvent*>(this);
 }
 
 const GestureEvent* Event::AsGestureEvent() const {
   CHECK(IsGestureEvent());
   return static_cast<const GestureEvent*>(this);
 }
 
@@ skipping 1115 matching lines @@
                    flags | EF_FROM_TOUCH),
       details_(details),
       unique_touch_event_id_(unique_touch_event_id) {
   latency()->set_source_event_type(ui::SourceEventType::TOUCH);
 }
 
 GestureEvent::~GestureEvent() {
 }
 
 }  // namespace ui