Refactored static_cast'ing of events to use the AsXXXEvent() methods.

ui/events/event_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/event_handler.h"
 
 #include "ui/events/event.h"
 #include "ui/events/event_dispatcher.h"
 
 namespace ui {
 
 EventHandler::EventHandler() {
 }
 
 EventHandler::~EventHandler() {
   while (!dispatchers_.empty()) {
     EventDispatcher* dispatcher = dispatchers_.top();
     dispatchers_.pop();
     dispatcher->OnHandlerDestroyed(this);
   }
 }
 
 void EventHandler::OnEvent(Event* event) {
-  // TODO(tdanderson): Encapsulate static_casts in ui::Event for all
-  //                   event types.

[kylix_rd, 2016/09/29 18:12:19]

I noticed this comment and had a couple of cycles to do some refactoring to use
the AsXXXEvent() methods instead of static_casts everywhere.

   if (event->IsKeyEvent())
-    OnKeyEvent(static_cast<KeyEvent*>(event));
+    OnKeyEvent(event->AsKeyEvent());
   else if (event->IsMouseEvent())
-    OnMouseEvent(static_cast<MouseEvent*>(event));
+    OnMouseEvent(event->AsMouseEvent());
   else if (event->IsScrollEvent())
-    OnScrollEvent(static_cast<ScrollEvent*>(event));
+    OnScrollEvent(event->AsScrollEvent());
   else if (event->IsTouchEvent())
-    OnTouchEvent(static_cast<TouchEvent*>(event));
+    OnTouchEvent(event->AsTouchEvent());
   else if (event->IsGestureEvent())
     OnGestureEvent(event->AsGestureEvent());
   else if (event->type() == ET_CANCEL_MODE)
     OnCancelMode(static_cast<CancelModeEvent*>(event));

[kylix_rd, 2016/09/29 18:12:19]

Should there be an AsCancelMode() method on Event? My guess is that it isn't
used enough to warrant it.

[rjkroege, 2016/10/03 17:42:45]

my sense of implementation "rightness" is that there probably should be an
AsCancelEvent

[kylix_rd, 2016/10/03 18:29:04]

Done.

 }
 
 void EventHandler::OnKeyEvent(KeyEvent* event) {
 }
 
 void EventHandler::OnMouseEvent(MouseEvent* event) {
 }
 
 void EventHandler::OnScrollEvent(ScrollEvent* event) {
 }
 
 void EventHandler::OnTouchEvent(TouchEvent* event) {
 }
 
 void EventHandler::OnGestureEvent(GestureEvent* event) {
 }
 
 void EventHandler::OnCancelMode(CancelModeEvent* event) {
 }
 
 }  // namespace ui