Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2374213002: Revert of Move registration of Java mojo interfaces to the new InterfaceRegistrar. (Closed)

Created:
4 years, 2 months ago by David Trainor- moved to gerrit
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, timvolodine, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@java-content-interface-registry
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move registration of Java mojo interfaces to the new InterfaceRegistrar. (patchset #5 id:300001 of https://codereview.chromium.org/2214383002/ ) Reason for revert: Looks like I have to revert this :(. Breaking the Chromium Android FYI bot. Basically Android doesn't actually include or build any native code from device/battery. It also doesn't depend on and build battery_monitor.mojom for certain targets. Sorry! See compile failures here: https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20(dbg) gn args to reproduce: enable_vr_shell = true ffmpeg_branding = "Chrome" is_component_build = false is_debug = true proprietary_codecs = true symbol_level = 1 target_os = "android" use_goma = true build targets to reproduce: chrome/browser/android/vr_shell chrome/browser/android/vr_shell:vr_shell_unittests Original issue's description: > Move registration of Java mojo interfaces to the new InterfaceRegistrar. > > Previously, Java-implemented mojo interfaces were registered on the C++ > InterfaceRegistries via JNI. This CL migrates those registrations to > dedicated Java InterfaceRegistries that C++ code can access via > corresponding InterfaceProviders. > > BUG=634568, 637174 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2 > Cr-Commit-Position: refs/heads/master@{#421403} TBR=rockot@chromium.org,boliu@chromium.org,jam@chromium.org,sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634568, 637174 Committed: https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2 Cr-Commit-Position: refs/heads/master@{#421642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -211 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java View 1 chunk +6 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImplementationFactory.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/mojo/chrome_interface_registrar_android.h View 1 chunk +20 lines, -1 line 0 comments Download
M chrome/browser/android/mojo/chrome_interface_registrar_android.cc View 1 chunk +18 lines, -5 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +3 lines, -14 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java View 1 chunk +94 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java View 3 chunks +0 lines, -37 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/NfcFactory.java View 1 chunk +0 lines, -61 lines 0 comments Download
M device/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M device/battery/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorFactory.java View 3 chunks +2 lines, -4 lines 0 comments Download
M device/vibration/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java View 2 chunks +0 lines, -16 lines 0 comments Download
M services/shell/public/cpp/interface_provider.h View 2 chunks +0 lines, -14 lines 0 comments Download
M services/shell/public/java/src/org/chromium/services/shell/InterfaceRegistry.java View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
David Trainor- moved to gerrit
Created Revert of Move registration of Java mojo interfaces to the new InterfaceRegistrar.
4 years, 2 months ago (2016-09-28 21:21:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374213002/1
4 years, 2 months ago (2016-09-28 21:22:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 21:23:36 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 21:27:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2
Cr-Commit-Position: refs/heads/master@{#421642}

Powered by Google App Engine
This is Rietveld 408576698