Chromium Code Reviews
DescriptionRevert of Move registration of Java mojo interfaces to the new InterfaceRegistrar. (patchset #5 id:300001 of https://codereview.chromium.org/2214383002/ )
Reason for revert:
Looks like I have to revert this :(. Breaking the Chromium Android FYI bot. Basically Android doesn't actually include or build any native code from device/battery. It also doesn't depend on and build battery_monitor.mojom for certain targets. Sorry!
See compile failures here:
https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20(dbg)
gn args to reproduce:
enable_vr_shell = true
ffmpeg_branding = "Chrome"
is_component_build = false
is_debug = true
proprietary_codecs = true
symbol_level = 1
target_os = "android"
use_goma = true
build targets to reproduce:
chrome/browser/android/vr_shell
chrome/browser/android/vr_shell:vr_shell_unittests
Original issue's description:
> Move registration of Java mojo interfaces to the new InterfaceRegistrar.
>
> Previously, Java-implemented mojo interfaces were registered on the C++
> InterfaceRegistries via JNI. This CL migrates those registrations to
> dedicated Java InterfaceRegistries that C++ code can access via
> corresponding InterfaceProviders.
>
> BUG=634568, 637174
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
> Cr-Commit-Position: refs/heads/master@{#421403}
TBR=rockot@chromium.org,boliu@chromium.org,jam@chromium.org,sammc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634568, 637174
Committed: https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2
Cr-Commit-Position: refs/heads/master@{#421642}
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|