Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 2374203003: Exclude LayoutTests/imported from pan-project checks in WebKit/PRESUBMIT.py. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude LayoutTests/imported from pan-project checks in WebKit/PRESUBMIT.py. For more context, see http://crrev.com/2374143003. Committed: https://crrev.com/d77e775c824a33fa969dc3e00c1d3963da7d90ac Cr-Commit-Position: refs/heads/master@{#421932}

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : Add comment. #

Patch Set 4 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/PRESUBMIT.py View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
qyearsley
4 years, 2 months ago (2016-09-28 22:13:40 UTC) #4
Dirk Pranke
lgtm, but this code is also being changed in https://codereview.chromium.org/2366153002/ so you should probably coordinate ...
4 years, 2 months ago (2016-09-28 22:19:21 UTC) #7
dcheng
It won't interfere with the clang-format staging patch too much, but I think it will ...
4 years, 2 months ago (2016-09-28 22:22:42 UTC) #9
qyearsley
On 2016/09/28 at 22:22:42, dcheng wrote: > It won't interfere with the clang-format staging patch ...
4 years, 2 months ago (2016-09-29 19:50:19 UTC) #10
dcheng
Seems reasonable to me, it's not too hard to fold this into the top-level PRESUBMIT ...
4 years, 2 months ago (2016-09-29 19:57:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374203003/60001
4 years, 2 months ago (2016-09-29 20:04:14 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-29 21:11:14 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 21:12:58 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d77e775c824a33fa969dc3e00c1d3963da7d90ac
Cr-Commit-Position: refs/heads/master@{#421932}

Powered by Google App Engine
This is Rietveld 408576698