Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2374203002: PrintPagesToSkPictures: observe WebFrame::getPrintPageShrink() (Closed)

Created:
4 years, 2 months ago by hal.canary
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PrintPagesToSkPictures: observe WebFrame::getPrintPageShrink() BUG=651847 Committed: https://crrev.com/ab360081194b7a5815f407666b748279cab0e384 Cr-Commit-Position: refs/heads/master@{#422218}

Patch Set 1 #

Patch Set 2 : rebase; work on linux #

Patch Set 3 : work on macos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 2 2 chunks +27 lines, -20 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
hal.canary
PTAL
4 years, 2 months ago (2016-09-28 21:06:13 UTC) #5
Ken Russell (switch to Gerrit)
LGTM Again, suggest adding tests for this and adding an associated bug ID.
4 years, 2 months ago (2016-09-29 00:21:24 UTC) #8
hal.canary
On 2016/09/29 00:21:24, Ken Russell wrote: > Again, suggest adding tests for this and See ...
4 years, 2 months ago (2016-09-30 18:39:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374203002/40001
4 years, 2 months ago (2016-09-30 18:39:34 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 21:03:57 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 21:07:49 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ab360081194b7a5815f407666b748279cab0e384
Cr-Commit-Position: refs/heads/master@{#422218}

Powered by Google App Engine
This is Rietveld 408576698