|
|
Chromium Code Reviews|
Created:
4 years, 2 months ago by hal.canary Modified:
4 years, 2 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrintPagesToSkPictures: observe WebFrame::getPrintPageShrink()
BUG=651847
Committed: https://crrev.com/ab360081194b7a5815f407666b748279cab0e384
Cr-Commit-Position: refs/heads/master@{#422218}
Patch Set 1 #Patch Set 2 : rebase; work on linux #Patch Set 3 : work on macos #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== PrintPagesToSkPictures: observe PrintPagesToSkPictures BUG= ========== to ========== PrintPagesToSkPictures: observe WebFrame::getPrintPageShrink() BUG= ==========
halcanary@google.com changed reviewers: + kbr@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM Again, suggest adding tests for this and adding an associated bug ID.
Description was changed from ========== PrintPagesToSkPictures: observe WebFrame::getPrintPageShrink() BUG= ========== to ========== PrintPagesToSkPictures: observe WebFrame::getPrintPageShrink() BUG=651847 ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/29 00:21:24, Ken Russell wrote: > Again, suggest adding tests for this and See https://codereview.chromium.org/2278653004 > adding an associated bug ID. Done
The CQ bit was unchecked by halcanary@google.com
The CQ bit was checked by halcanary@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2374203002/#ps40001 (title: "work on macos")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== PrintPagesToSkPictures: observe WebFrame::getPrintPageShrink() BUG=651847 ========== to ========== PrintPagesToSkPictures: observe WebFrame::getPrintPageShrink() BUG=651847 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== PrintPagesToSkPictures: observe WebFrame::getPrintPageShrink() BUG=651847 ========== to ========== PrintPagesToSkPictures: observe WebFrame::getPrintPageShrink() BUG=651847 Committed: https://crrev.com/ab360081194b7a5815f407666b748279cab0e384 Cr-Commit-Position: refs/heads/master@{#422218} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ab360081194b7a5815f407666b748279cab0e384 Cr-Commit-Position: refs/heads/master@{#422218} |
