Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 23742005: Check the sample rate before passing the audio params to webrtc audio renderer (Closed)

Created:
7 years, 3 months ago by no longer working on chromium
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Check the sample rate before passing the device specific audio params to webrtc audio renderer. This fixes the problem on some platforms where it does not support query the audio params of specific device. R=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/renderer/media/media_stream_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
no longer working on chromium
7 years, 3 months ago (2013-09-10 09:02:02 UTC) #1
tommi (sloooow) - chröme
lgtm
7 years, 3 months ago (2013-09-10 09:02:50 UTC) #2
no longer working on chromium
7 years, 3 months ago (2013-09-10 09:03:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r222230 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698