Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: components/autofill/content/renderer/password_generation_manager.h

Issue 23742004: Move PasswordForm from //content to //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_password_form_conversion_utils
Patch Set: Response to review Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_generation_manager.h
diff --git a/components/autofill/content/renderer/password_generation_manager.h b/components/autofill/content/renderer/password_generation_manager.h
index a61542861677bbef405e9fabb77c9ed2d9939b24..20f69a1112a3ae28e145ca5cbf16e05f4acb732f 100644
--- a/components/autofill/content/renderer/password_generation_manager.h
+++ b/components/autofill/content/renderer/password_generation_manager.h
@@ -19,12 +19,10 @@ class WebCString;
class WebDocument;
}
-namespace content {
-struct PasswordForm;
-}
-
namespace autofill {
+struct PasswordForm;
+
// This class is responsible for controlling communication for password
// generation between the browser (which shows the popup and generates
// passwords) and WebKit (shows the generation icon in the password field).
@@ -51,7 +49,7 @@ class PasswordGenerationManager : public content::RenderViewObserver,
virtual void openPasswordGenerator(WebKit::WebInputElement& element) OVERRIDE;
// Message handlers.
- void OnFormNotBlacklisted(const content::PasswordForm& form);
+ void OnFormNotBlacklisted(const autofill::PasswordForm& form);
Ilya Sherman 2013/09/05 22:53:35 nit: No need for namespace.
blundell 2013/09/06 08:36:25 Done.
void OnPasswordAccepted(const base::string16& password);
void OnPasswordGenerationEnabled(bool enabled);

Powered by Google App Engine
This is Rietveld 408576698