Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.h

Issue 23742004: Move PasswordForm from //content to //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_password_form_conversion_utils
Patch Set: Response to review Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_form_conversion_utils.h
diff --git a/components/autofill/content/renderer/password_form_conversion_utils.h b/components/autofill/content/renderer/password_form_conversion_utils.h
index 0abaeede46dc2e1359275e3f12324bc4d55037c2..b094f853e6919589ae083be21ab7c9f81fd1958c 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils.h
+++ b/components/autofill/content/renderer/password_form_conversion_utils.h
@@ -7,21 +7,19 @@
#include "base/memory/scoped_ptr.h"
-namespace content {
-struct PasswordForm;
-}
-
namespace WebKit {
class WebFormElement;
}
namespace autofill {
+struct PasswordForm;
+
// Create a PasswordForm from DOM form. Webkit doesn't allow storing
// custom metadata to DOM nodes, so we have to do this every time an event
// happens with a given form and compare against previously Create'd forms
// to identify..which sucks.
-scoped_ptr<content::PasswordForm> CreatePasswordForm(
+scoped_ptr<autofill::PasswordForm> CreatePasswordForm(
Ilya Sherman 2013/09/05 22:53:35 nit: No need for namespace.
blundell 2013/09/06 08:36:25 Done.
const WebKit::WebFormElement& form);
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698