chrome/utility/importer/firefox_importer.cc - Issue 23742004: Move PasswordForm from //content to //autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/firefox_importer.cc

Issue 23742004: Move PasswordForm from //content to //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_password_form_conversion_utils

Patch Set: Response to review Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/utility/importer/external_process_importer_bridge.cc ('k') | chrome/utility/importer/ie_importer_win.cc » ('j') | components/autofill/content/renderer/password_form_conversion_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/utility/importer/firefox_importer.cc

diff --git a/chrome/utility/importer/firefox_importer.cc b/chrome/utility/importer/firefox_importer.cc

index e1474dbd683420e364364801c5dd87b94419248b..ab7d2966ec605cc90cc5aa594bd556413dc1731a 100644

--- a/chrome/utility/importer/firefox_importer.cc

+++ b/chrome/utility/importer/firefox_importer.cc

@@ -22,7 +22,7 @@

#include "chrome/utility/importer/bookmark_html_reader.h"

#include "chrome/utility/importer/favicon_reencode.h"

#include "chrome/utility/importer/nss_decryptor.h"

-#include "content/public/common/password_form.h"

+#include "components/autofill/core/common/password_form.h"

#include "grit/generated_resources.h"

#include "sql/connection.h"

#include "sql/statement.h"

@@ -343,7 +343,7 @@ void FirefoxImporter::ImportPasswords() {

return;

}

- std::vector<content::PasswordForm> forms;

+ std::vector<autofill::PasswordForm> forms;

base::FilePath source_path = source_path_;

base::FilePath file = source_path.AppendASCII("signons.sqlite");

if (base::PathExists(file)) {