chrome/browser/password_manager/password_generation_manager.cc - Issue 23742004: Move PasswordForm from //content to //autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_generation_manager.cc

Issue 23742004: Move PasswordForm from //content to //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_password_form_conversion_utils

Patch Set: Response to review Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_generation_manager.h ('k') | chrome/browser/password_manager/password_manager.h » ('j') | components/autofill/content/renderer/password_form_conversion_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_generation_manager.cc

diff --git a/chrome/browser/password_manager/password_generation_manager.cc b/chrome/browser/password_manager/password_generation_manager.cc

index e53f61a7b682589a664f9ab33aa35e8a7133edcd..79d24882ebdf5ab378a2ffffa65ec06077b1b248 100644

--- a/chrome/browser/password_manager/password_generation_manager.cc

+++ b/chrome/browser/password_manager/password_generation_manager.cc

@@ -15,11 +15,11 @@

#include "chrome/common/pref_names.h"

#include "components/autofill/core/browser/password_generator.h"

#include "components/autofill/core/common/autofill_messages.h"

+#include "components/autofill/core/common/password_form.h"

#include "components/user_prefs/pref_registry_syncable.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

-#include "content/public/common/password_form.h"

#include "ipc/ipc_message_macros.h"

#include "ui/gfx/rect.h"

@@ -154,7 +154,7 @@ void PasswordGenerationManager::SendStateToRenderer(

void PasswordGenerationManager::OnShowPasswordGenerationPopup(

const gfx::Rect& bounds,

int max_length,

- const content::PasswordForm& form) {

+ const autofill::PasswordForm& form) {

#if defined(OS_ANDROID)

NOTIMPLEMENTED();

#else