Source/web/tests/WebFrameTest.cpp - Issue 23742003: Use css-device-adapt constraining for legacy viewport tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 23742003: Use css-device-adapt constraining for legacy viewport tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More review issues Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 0aff89cd3852d81b7ee3cc3806ee06ecfc121a19..a2c17d639b883e0325c166ce5b9758c67c8ba2f7 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -371,7 +371,8 @@ TEST_F(WebFrameTest, ChangeInFixedLayoutTriggersTextAutosizingRecalculate)

EXPECT_TRUE(multiplierSetAtLeastOnce);

WebCore::ViewportArguments arguments = document->viewportArguments();

- arguments.width += 10;

+ // Choose a width that's not going match the viewport width of the loaded document.

+ arguments.minWidth = arguments.maxWidth = WebCore::Length(100, WebCore::Fixed);

webViewImpl()->updatePageDefinedPageScaleConstraints(arguments);

bool multiplierCheckedAtLeastOnce = false;

« Source/core/dom/Document.cpp ('K') | « Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »