Source/core/page/PageScaleConstraintsSet.h - Issue 23742003: Use css-device-adapt constraining for legacy viewport tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/PageScaleConstraintsSet.h

Issue 23742003: Use css-device-adapt constraining for legacy viewport tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More review issues Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/PageScaleConstraintsSet.h

diff --git a/Source/core/page/PageScaleConstraintsSet.h b/Source/core/page/PageScaleConstraintsSet.h

index 8cdc08b48dc774a64e45ef84c93dc5141b14cb38..2f43bc11628d81288d6ccf12a03c545d78bd31b4 100644

--- a/Source/core/page/PageScaleConstraintsSet.h

+++ b/Source/core/page/PageScaleConstraintsSet.h

@@ -48,7 +48,7 @@ public:

// Settings defined in the website's viewport tag, if viewport tag support

// is enabled.

const PageScaleConstraints& pageDefinedConstraints() const { return m_pageDefinedConstraints; }

- void updatePageDefinedConstraints(const ViewportArguments&, IntSize viewSize, int layoutFallbackWidth);

+ void updatePageDefinedConstraints(const ViewportArguments&, IntSize viewSize);

void adjustPageDefinedConstraintsForAndroidWebView(const ViewportArguments&, IntSize viewSize, int layoutFallbackWidth, float deviceScaleFactor, bool useWideViewport, bool loadWithOverviewMode);

// Constraints may also be set from Chromium -- this overrides any

« Source/core/dom/Document.cpp ('K') | « Source/core/dom/ViewportArguments.cpp ('k') | Source/core/page/PageScaleConstraintsSet.cpp » ('j') | no next file with comments »