Source/core/css/RuleSet.cpp - Issue 23742003: Use css-device-adapt constraining for legacy viewport tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/RuleSet.cpp

Issue 23742003: Use css-device-adapt constraining for legacy viewport tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More review issues Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/RuleSet.cpp

diff --git a/Source/core/css/RuleSet.cpp b/Source/core/css/RuleSet.cpp

index d7d56bfa00d70b4c35c69787d068665af8bee9db..2ffda78c0c6b383e914e434ce39743c7f0a64836 100644

--- a/Source/core/css/RuleSet.cpp

+++ b/Source/core/css/RuleSet.cpp

@@ -393,7 +393,7 @@ void RuleSet::addChildRules(const Vector<RefPtr<StyleRuleBase> >& rules, const M

resolver->setBuildScopedStyleTreeInDocumentOrder(false);

resolver->ensureScopedStyleResolver(scope->shadowHost())->addHostRule(static_cast<StyleRuleHost*>(rule), hasDocumentSecurityOrigin, scope);

resolver->setBuildScopedStyleTreeInDocumentOrder(enabled);

- } else if (RuntimeEnabledFeatures::cssViewportEnabled() && rule->isViewportRule()) {

+ } else if (rule->isViewportRule()) {

// @viewport should not be scoped.

if (!isDocumentScope(scope))

continue;

« Source/core/css/CSSParser-in.cpp ('K') | « Source/core/css/CSSParser-in.cpp ('k') | Source/core/css/StyleRule.cpp » ('j') | Source/core/css/resolver/StyleResolver.cpp » ('J')