Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: base/trace_event/trace_event.h

Issue 2374193002: Make base::PendingTask support ConvertableToTraceFormat (Closed)
Patch Set: JsonWriter::Write requires a temp var Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/pending_task.cc ('K') | « base/pending_task.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event.h
diff --git a/base/trace_event/trace_event.h b/base/trace_event/trace_event.h
index 4de64837161fded5fd176d1dc5136006d8521a9e..1105429fd8e261495a55a3b86c3fc8b036e8b331 100644
--- a/base/trace_event/trace_event.h
+++ b/base/trace_event/trace_event.h
@@ -438,11 +438,9 @@ TRACE_EVENT_API_CLASS_EXPORT extern \
// Implementation detail: internal macro to trace a task execution with the
// location where it was posted from.
-#define INTERNAL_TRACE_TASK_EXECUTION(run_function, task) \
- TRACE_EVENT2("toplevel", run_function, "src_file", \
- (task).posted_from.file_name(), "src_func", \
- (task).posted_from.function_name()); \
- TRACE_HEAP_PROFILER_API_SCOPED_TASK_EXECUTION INTERNAL_TRACE_EVENT_UID( \
+#define INTERNAL_TRACE_TASK_EXECUTION(run_function, task) \
Sami 2016/10/04 11:25:31 I believe there are a number of tools (e.g., Light
+ TRACE_EVENT1("toplevel", run_function, "src_info", (task).GetTracingInfo()); \
+ TRACE_HEAP_PROFILER_API_SCOPED_TASK_EXECUTION INTERNAL_TRACE_EVENT_UID( \
task_event)((task).posted_from.file_name());
namespace trace_event_internal {
« base/pending_task.cc ('K') | « base/pending_task.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698