[Android] Run shell commands from the forwarder without passing fds.

[Android] Run shell commands from the forwarder without passing fds.

The forwarder daemon was running commands with system(). This would give
the newly forked process copies of the same file handles held by the
daemon, notably including the unix domain socket.

If the adb server wasn't already running and the daemon called an adb
command, the adb server would be forked from the adb client process
with those same file handles -- including the unix domain socket. This
would interfere both with shutting down the host forwarder daemon
(as we'd see the unix domain socket still held by the adb server) and
with subsequent attempts to bring it up (same reason).

BUG=634052, 650674
Committed: https://crrev.com/dccd754c3b5cc5be5c809ffd6a9b742053f25c76
Cr-Commit-Position: refs/heads/master@{#422263}

[jbudorick, 2016-09-30 21:07:15]

jbudorick@chromium.org changed reviewers:
+ agrieve@chromium.org

[jbudorick, 2016-09-30 21:07:50]

The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 21:08:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 21:18:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 21:18:54]

Dry run: This issue passed the CQ dry run.

[jbudorick, 2016-10-01 00:11:58]

jbudorick@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2016-10-01 00:45:20]

lgtm

[jbudorick, 2016-10-01 00:50:57]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-10-01 00:51:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 01:51:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-01 01:55:31]

Description was changed from

==========
[Android] Run shell commands from the forwarder without passing fds.

The forwarder daemon was running commands with system(). This would give
the newly forked process copies of the same file handles held by the
daemon, notably including the unix domain socket.

If the adb server wasn't already running and the daemon called an adb
command, the adb server would be forked from the adb client process
with those same file handles -- including the unix domain socket. This
would interfere both with shutting down the host forwarder daemon
(as we'd see the unix domain socket still held by the adb server) and
with subsequent attempts to bring it up (same reason).

BUG=634052,650674
==========

to

==========
[Android] Run shell commands from the forwarder without passing fds.

The forwarder daemon was running commands with system(). This would give
the newly forked process copies of the same file handles held by the
daemon, notably including the unix domain socket.

If the adb server wasn't already running and the daemon called an adb
command, the adb server would be forked from the adb client process
with those same file handles -- including the unix domain socket. This
would interfere both with shutting down the host forwarder daemon
(as we'd see the unix domain socket still held by the adb server) and
with subsequent attempts to bring it up (same reason).

BUG=634052,650674

Committed: https://crrev.com/dccd754c3b5cc5be5c809ffd6a9b742053f25c76
Cr-Commit-Position: refs/heads/master@{#422263}
==========

[commit-bot: I haz the power, 2016-10-01 01:55:32]

Patchset 1 (id:??) landed as
https://crrev.com/dccd754c3b5cc5be5c809ffd6a9b742053f25c76
Cr-Commit-Position: refs/heads/master@{#422263}