Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: cc/output/gl_renderer.cc

Issue 2374183006: Remove GLFrameData from CompositorFrame. (Closed)
Patch Set: Address comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/gl_renderer.cc
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index b882c276b594f23dbbd097ac8f57f3cf7bcd3b29..fb0388aec57e5419ba4b96b84d80a85330bf74d7 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -26,14 +26,12 @@
#include "build/build_config.h"
#include "cc/base/container_util.h"
#include "cc/base/math_util.h"
-#include "cc/output/compositor_frame.h"
-#include "cc/output/compositor_frame_metadata.h"
#include "cc/output/context_provider.h"
#include "cc/output/copy_output_request.h"
#include "cc/output/dynamic_geometry_binding.h"
-#include "cc/output/gl_frame_data.h"
#include "cc/output/layer_quad.h"
#include "cc/output/output_surface.h"
+#include "cc/output/output_surface_frame.h"
#include "cc/output/render_surface_filters.h"
#include "cc/output/renderer_settings.h"
#include "cc/output/static_geometry_binding.h"
@@ -2884,7 +2882,7 @@ void GLRenderer::DrawQuadGeometry(const gfx::Transform& projection_matrix,
gl_->DrawElements(GL_TRIANGLES, 6, GL_UNSIGNED_SHORT, 0);
}
-void GLRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
+void GLRenderer::SwapBuffers(std::vector<ui::LatencyInfo> latency_info) {
DCHECK(visible_);
TRACE_EVENT0("cc,benchmark", "GLRenderer::SwapBuffers");
@@ -2892,10 +2890,9 @@ void GLRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
gfx::Size surface_size = output_surface_->SurfaceSize();
- CompositorFrame compositor_frame;
- compositor_frame.metadata = std::move(metadata);
- compositor_frame.gl_frame_data = base::WrapUnique(new GLFrameData);
- compositor_frame.gl_frame_data->size = surface_size;
+ OutputSurfaceFrame output_frame;
+ output_frame.latency_info = std::move(latency_info);
+ output_frame.size = surface_size;
if (use_partial_swap_) {
// If supported, we can save significant bandwidth by only swapping the
// damaged/scissored region (clamped to the viewport).
@@ -2903,7 +2900,7 @@ void GLRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
int flipped_y_pos_of_rect_bottom = surface_size.height() -
swap_buffer_rect_.y() -
swap_buffer_rect_.height();
- compositor_frame.gl_frame_data->sub_buffer_rect =
+ output_frame.sub_buffer_rect =
gfx::Rect(swap_buffer_rect_.x(),
FlippedRootFramebuffer() ? flipped_y_pos_of_rect_bottom
: swap_buffer_rect_.y(),
@@ -2914,13 +2911,13 @@ void GLRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
if (!swap_buffer_rect_.IsEmpty() || !allow_empty_swap_) {
swap_buffer_rect_ = gfx::Rect(surface_size);
}
- compositor_frame.gl_frame_data->sub_buffer_rect = swap_buffer_rect_;
+ output_frame.sub_buffer_rect = swap_buffer_rect_;
}
swapping_overlay_resources_.push_back(std::move(pending_overlay_resources_));
pending_overlay_resources_.clear();
- output_surface_->SwapBuffers(std::move(compositor_frame));
+ output_surface_->SwapBuffers(std::move(output_frame));
swap_buffer_rect_ = gfx::Rect();
}

Powered by Google App Engine
This is Rietveld 408576698