android_webview/browser/hardware_renderer.cc - Issue 2374183006: Remove GLFrameData from CompositorFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/hardware_renderer.cc

Issue 2374183006: Remove GLFrameData from CompositorFrame. (Closed)

Patch Set: Address comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/hardware_renderer.cc

diff --git a/android_webview/browser/hardware_renderer.cc b/android_webview/browser/hardware_renderer.cc

index 56b9e008b26eee3dd6dc7baad8b2117f24b12de6..d4c25f4860e1621d664076dce2690981e4cee59b 100644

--- a/android_webview/browser/hardware_renderer.cc

+++ b/android_webview/browser/hardware_renderer.cc

@@ -68,7 +68,6 @@ void HardwareRenderer::CommitFrame() {

ReturnResourcesInChildFrame();

child_frame_ = std::move(child_frame);

DCHECK(child_frame_->frame.get());

- DCHECK(!child_frame_->frame->gl_frame_data);

}

void HardwareRenderer::DrawGL(AwDrawGLInfo* draw_info) {