Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: cc/output/software_renderer.cc

Issue 2374183006: Remove GLFrameData from CompositorFrame. (Closed)
Patch Set: Rebase + fix includes. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/software_renderer.cc
diff --git a/cc/output/software_renderer.cc b/cc/output/software_renderer.cc
index b0c28353b74c612f9792d6b530044d86f750d60f..90d08014670ebc11408475f249687186bb8d1ffb 100644
--- a/cc/output/software_renderer.cc
+++ b/cc/output/software_renderer.cc
@@ -7,10 +7,10 @@
#include "base/memory/ptr_util.h"
#include "base/trace_event/trace_event.h"
#include "cc/base/math_util.h"
-#include "cc/output/compositor_frame.h"
#include "cc/output/compositor_frame_metadata.h"
#include "cc/output/copy_output_request.h"
#include "cc/output/output_surface.h"
+#include "cc/output/output_surface_frame.h"
#include "cc/output/render_surface_filters.h"
#include "cc/output/renderer_settings.h"
#include "cc/output/software_output_device.h"
@@ -84,9 +84,9 @@ void SoftwareRenderer::FinishDrawingFrame(DrawingFrame* frame) {
void SoftwareRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
danakj 2016/10/04 21:58:40 same here, can it take vector instead of full meta
kylechar 2016/10/05 13:45:54 Done.
DCHECK(visible_);
TRACE_EVENT0("cc,benchmark", "SoftwareRenderer::SwapBuffers");
- CompositorFrame compositor_frame;
- compositor_frame.metadata = std::move(metadata);
- output_surface_->SwapBuffers(std::move(compositor_frame));
+ OutputSurfaceFrame frame;
danakj 2016/10/04 21:58:40 nit: output_frame or something?
kylechar 2016/10/05 13:45:54 Done.
+ frame.latency_info = std::move(metadata.latency_info);
+ output_surface_->SwapBuffers(std::move(frame));
}
bool SoftwareRenderer::FlippedFramebuffer(const DrawingFrame* frame) const {

Powered by Google App Engine
This is Rietveld 408576698