Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: runtime/vm/stub_code_ia32.cc

Issue 2374173002: Revert "Pass new pool pointer to the JumpToException stub instead of reloading in through the frame… (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1767 matching lines...) Expand 10 before | Expand all | Expand 10 after
1778 1778
1779 1779
1780 // Jump to the exception or error handler. 1780 // Jump to the exception or error handler.
1781 // TOS + 0: return address 1781 // TOS + 0: return address
1782 // TOS + 1: program_counter 1782 // TOS + 1: program_counter
1783 // TOS + 2: stack_pointer 1783 // TOS + 2: stack_pointer
1784 // TOS + 3: frame_pointer 1784 // TOS + 3: frame_pointer
1785 // TOS + 4: exception object 1785 // TOS + 4: exception object
1786 // TOS + 5: stacktrace object 1786 // TOS + 5: stacktrace object
1787 // TOS + 6: thread 1787 // TOS + 6: thread
1788 // TOS + 7: pool pointer (unused)
1789 // No Result. 1788 // No Result.
1790 void StubCode::GenerateJumpToExceptionHandlerStub(Assembler* assembler) { 1789 void StubCode::GenerateJumpToExceptionHandlerStub(Assembler* assembler) {
1791 ASSERT(kExceptionObjectReg == EAX); 1790 ASSERT(kExceptionObjectReg == EAX);
1792 ASSERT(kStackTraceObjectReg == EDX); 1791 ASSERT(kStackTraceObjectReg == EDX);
1793 __ movl(THR, Address(ESP, 6 * kWordSize)); // Load target thread. 1792 __ movl(THR, Address(ESP, 6 * kWordSize)); // Load target thread.
1794 __ movl(kStackTraceObjectReg, Address(ESP, 5 * kWordSize)); 1793 __ movl(kStackTraceObjectReg, Address(ESP, 5 * kWordSize));
1795 __ movl(kExceptionObjectReg, Address(ESP, 4 * kWordSize)); 1794 __ movl(kExceptionObjectReg, Address(ESP, 4 * kWordSize));
1796 __ movl(EBP, Address(ESP, 3 * kWordSize)); // Load target frame_pointer. 1795 __ movl(EBP, Address(ESP, 3 * kWordSize)); // Load target frame_pointer.
1797 __ movl(EBX, Address(ESP, 1 * kWordSize)); // Load target PC into EBX. 1796 __ movl(EBX, Address(ESP, 1 * kWordSize)); // Load target PC into EBX.
1798 __ movl(ESP, Address(ESP, 2 * kWordSize)); // Load target stack_pointer. 1797 __ movl(ESP, Address(ESP, 2 * kWordSize)); // Load target stack_pointer.
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
2038 } 2037 }
2039 2038
2040 2039
2041 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) { 2040 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) {
2042 __ int3(); 2041 __ int3();
2043 } 2042 }
2044 2043
2045 } // namespace dart 2044 } // namespace dart
2046 2045
2047 #endif // defined TARGET_ARCH_IA32 2046 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698