Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2374173002: Revert "Pass new pool pointer to the JumpToException stub instead of reloading in through the frame… (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Pass new pool pointer to the JumpToException stub instead of reloading in through the frame's Code object." This reverts commit 3413e052b30ee12ad41cb73a7f1abb50bba2a3ae. Committed: https://github.com/dart-lang/sdk/commit/e3420eab29f8c6a44a196f98600b63ed21919c7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -134 lines) Patch
M runtime/vm/exceptions.cc View 17 chunks +7 lines, -37 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/simulator_arm.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/simulator_arm64.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M runtime/vm/simulator_dbc.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/simulator_mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/simulator_mips.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/stack_frame.h View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/stub_code_mips.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
D tests/language/vm/lazy_deopt_with_exception_and_stacktrace_test.dart View 1 chunk +0 lines, -67 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 2 months ago (2016-09-28 19:59:19 UTC) #2
rmacnak
Committed patchset #1 (id:1) manually as e3420eab29f8c6a44a196f98600b63ed21919c7c (presubmit successful).
4 years, 2 months ago (2016-09-28 20:00:09 UTC) #4
Florian Schneider
4 years, 2 months ago (2016-09-28 20:07:54 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698