Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2374153004: [DevTools] Fix compile_frontend.py script (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix compile_frontend.py script DebuggerScript and InjectedScriptSource compilation were moved to V8 presubmit scripts. BUG=chromium:635948 TBR=dgozman@chromium.org Committed: https://crrev.com/ac9f2c655ced2517922cce95a0c34b494d7fc6b0 Cr-Commit-Position: refs/heads/master@{#421853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -155 lines) Patch
D third_party/WebKit/Source/devtools/scripts/check_injected_script_source.py View 1 chunk +0 lines, -84 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/compile_frontend.py View 6 chunks +6 lines, -71 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
kozy
please take a look.
4 years, 2 months ago (2016-09-29 16:12:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374153004/1
4 years, 2 months ago (2016-09-29 16:32:43 UTC) #7
dgozman
lgtm
4 years, 2 months ago (2016-09-29 16:42:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374153004/1
4 years, 2 months ago (2016-09-29 17:03:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 17:09:09 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 17:10:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac9f2c655ced2517922cce95a0c34b494d7fc6b0
Cr-Commit-Position: refs/heads/master@{#421853}

Powered by Google App Engine
This is Rietveld 408576698