Fix compilation error in Vulkan Renderer header file

Fix compilation error in Vulkan Renderer header file

The commit https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92 deletes the
header file 'cc/output/renderer.h'.

Removed the header file 'cc/output/renderer.h' present in source file.

BUG=582564
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ba30ac8b6ef61ce4e71a01c41cd717a3822fa9c2
Cr-Commit-Position: refs/heads/master@{#423086}

[Soorya, 2016-09-29 13:09:43]

Description was changed from

==========
Renderer header file is removed from cc

As renderer.h is removed from cc/output this header file need to
be deleted.

BUG=582564
==========

to

==========
Renderer header file is removed from cc

As renderer.h is removed from cc/output this header file need to
be deleted.

BUG=582564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Soorya, 2016-09-30 06:27:48]

Description was changed from

==========
Renderer header file is removed from cc

As renderer.h is removed from cc/output this header file need to
be deleted.

BUG=582564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Renderer header file is removed from cc

As renderer.h is removed from cc/output this header file need to
be deleted.

BUG=582564
==========

[Soorya, 2016-09-30 06:45:09]

soorya.r@samsung.com changed reviewers:
+ aelias@chromium.org

[a.suchit2, 2016-10-03 11:55:11]

On 2016/09/30 06:45:09, Soorya wrote:
> mailto:soorya.r@samsung.com changed reviewers:
> + mailto:aelias@chromium.org

Please give the information about commit in description which is removing
cc/output/renderer.h, like below

Committed: https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92 is deleted
header file 'cc/output/renderer.h'.

Removed header file 'cc/output/renderer.h' present in source file.

[Soorya, 2016-10-03 12:24:34]

Description was changed from

==========
Renderer header file is removed from cc

As renderer.h is removed from cc/output this header file need to
be deleted.

BUG=582564
==========

to

==========
The commit https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92 deletes
the
header file 'cc/output/renderer.h'.

Removed the header file 'cc/output/renderer.h' present in source file.

BUG=582564
==========

[a.suchit2, 2016-10-03 12:50:59]

Peer review looks good to me.

[Soorya, 2016-10-03 12:52:00]

soorya.r@samsung.com changed reviewers:
+ enne@chromium.org

[Soorya, 2016-10-03 12:54:53]

The CQ bit was checked by soorya.r@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 12:55:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 12:55:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 12:55:07]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[a.suchit2, 2016-10-03 13:03:43]

The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 13:03:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 13:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 13:03:50]

Dry run: The author soorya.r@samsung.com has not signed Google Contributor
License Agreement. Please visit https://cla.developers.google.com to sign and
manage CLA.

[aelias_OOO_until_Jul13, 2016-10-03 19:26:47]

enne@/vmiura@, should these dead code files be entirely deleted instead?  Our
latest plan for Vulkan will involve a class called something like SkiaRenderer,
not VulkanRenderer, right?

(Looks like these were introduced by dyen@ who has left the project.)

[enne (OOO), 2016-10-03 19:39:02]

On 2016/10/03 at 19:26:47, aelias wrote:
> enne@/vmiura@, should these dead code files be entirely deleted instead?  Our
latest plan for Vulkan will involve a class called something like SkiaRenderer,
not VulkanRenderer, right?
> 
> (Looks like these were introduced by dyen@ who has left the project.)

I'm not sure what the state of ENABLE_VULKAN in the codebase is.  vmiura, do you
know better?

That said, it's unclear what we're going to need to do in the future, re:
SkiaRenderer vs VulkanRenderer.  SkiaRenderer for gl has a lot of overhead (too
much overhead to ship, imo).  I don't have enough information yet to know if
it's doing something obviously wrong or how much we can close that gap.

[vmiura, 2016-10-03 19:59:39]

On 2016/10/03 19:39:02, enne wrote:
> On 2016/10/03 at 19:26:47, aelias wrote:
> > enne@/vmiura@, should these dead code files be entirely deleted instead? 
Our
> latest plan for Vulkan will involve a class called something like
SkiaRenderer,
> not VulkanRenderer, right?
> > 
> > (Looks like these were introduced by dyen@ who has left the project.)
> 
> I'm not sure what the state of ENABLE_VULKAN in the codebase is.  vmiura, do
you
> know better?
> 
> That said, it's unclear what we're going to need to do in the future, re:
> SkiaRenderer vs VulkanRenderer.  SkiaRenderer for gl has a lot of overhead
(too
> much overhead to ship, imo).  I don't have enough information yet to know if
> it's doing something obviously wrong or how much we can close that gap.

ENABLE_VULKAN enables a number of things I think we will still use (Vulkan
contexts, display utilities, see
https://cs.chromium.org/chromium/src/gpu/vulkan/BUILD.gn)

As enne@ mentioned it's unclear what we're going to do.  There's nothing
interesting in these files yet, but as it's behind the flag I would just leave
them for now.

[aelias_OOO_until_Jul13, 2016-10-03 20:41:36]

Description was changed from

==========
The commit https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92 deletes
the
header file 'cc/output/renderer.h'.

Removed the header file 'cc/output/renderer.h' present in source file.

BUG=582564
==========

to

==========
Fix compilation error in Vulkan Renderer header file

The commit https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92 deletes
the
header file 'cc/output/renderer.h'.

Removed the header file 'cc/output/renderer.h' present in source file.

BUG=582564
==========

[aelias_OOO_until_Jul13, 2016-10-03 20:42:21]

OK, may as well land this then.  lgtm

[aelias_OOO_until_Jul13, 2016-10-03 20:43:01]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:43:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:43:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:43:51]

The author soorya.r@samsung.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[Soorya, 2016-10-04 13:02:28]

Description was changed from

==========
Fix compilation error in Vulkan Renderer header file

The commit https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92 deletes
the
header file 'cc/output/renderer.h'.

Removed the header file 'cc/output/renderer.h' present in source file.

BUG=582564
==========

to

==========
Fix compilation error in Vulkan Renderer header file

The commit https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92 deletes
the
header file 'cc/output/renderer.h'.

Removed the header file 'cc/output/renderer.h' present in source file.

BUG=582564
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Soorya, 2016-10-04 13:06:33]

Patchset #5 (id:80001) has been deleted

[Soorya, 2016-10-04 13:06:44]

Patchset #4 (id:60001) has been deleted

[a.suchit2, 2016-10-05 05:20:03]

The CQ bit was checked by a.suchit@chromium.org

[commit-bot: I haz the power, 2016-10-05 05:20:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 05:29:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 05:29:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Soorya, 2016-10-05 05:47:59]

The CQ bit was checked by soorya.r@samsung.com

[Soorya, 2016-10-05 05:47:59]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/2374143006/#ps100001
(title: "Added name in AUTHOR file")

[commit-bot: I haz the power, 2016-10-05 05:48:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 06:12:11]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-10-05 06:15:19]

Description was changed from

==========
Fix compilation error in Vulkan Renderer header file

The commit https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92 deletes
the
header file 'cc/output/renderer.h'.

Removed the header file 'cc/output/renderer.h' present in source file.

BUG=582564
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix compilation error in Vulkan Renderer header file

The commit https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92 deletes
the
header file 'cc/output/renderer.h'.

Removed the header file 'cc/output/renderer.h' present in source file.

BUG=582564
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ba30ac8b6ef61ce4e71a01c41cd717a3822fa9c2
Cr-Commit-Position: refs/heads/master@{#423086}
==========

[commit-bot: I haz the power, 2016-10-05 06:15:21]

Patchset 4 (id:??) landed as
https://crrev.com/ba30ac8b6ef61ce4e71a01c41cd717a3822fa9c2
Cr-Commit-Position: refs/heads/master@{#423086}