Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 2374143005: Update pub, making --packages-dir false by default (Closed)

Created:
4 years, 2 months ago by Bill Hesse
Modified:
4 years, 2 months ago
Reviewers:
Bob Nystrom, kustermann
CC:
reviews_dartlang.org, Bob Nystrom, mit, kevmoo
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update pub, making --packages-dir false by default BUG=https://github.com/dart-lang/sdk/issues/27399 BUG=https://github.com/dart-lang/pub/issues/1450 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/c20e2a0883a43a75ac18d5db6f8d32dfabf34f83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Bill Hesse
4 years, 2 months ago (2016-09-29 11:53:37 UTC) #2
kustermann
lgtm
4 years, 2 months ago (2016-09-29 11:58:09 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as c20e2a0883a43a75ac18d5db6f8d32dfabf34f83 (presubmit successful).
4 years, 2 months ago (2016-09-29 12:01:20 UTC) #5
Bob Nystrom
4 years, 2 months ago (2016-09-29 17:06:17 UTC) #7
Message was sent while issue was closed.
LGTM, thanks!

I was going to update this this morning, but you beat me to it. :)

Powered by Google App Engine
This is Rietveld 408576698